Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make non-TTY output consistent with progress bar freezing #521

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 26, 2023

Fixes #520

@emmercm emmercm self-assigned this Jul 26, 2023
@emmercm emmercm enabled auto-merge (squash) July 26, 2023 23:41
@codecov-commenter
Copy link

Codecov Report

Merging #521 (32ecca1) into main (8b1a5b3) will decrease coverage by 0.02%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
- Coverage   93.49%   93.47%   -0.02%     
==========================================
  Files          73       73              
  Lines        4334     4340       +6     
  Branches      911      912       +1     
==========================================
+ Hits         4052     4057       +5     
- Misses        268      269       +1     
  Partials       14       14              
Files Changed Coverage Δ
src/console/singleBarFormatted.ts 81.05% <80.00%> (ø)
src/console/progressBarCLI.ts 95.08% <91.66%> (-0.61%) ⬇️
src/igir.ts 100.00% <100.00%> (ø)

@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/non-tty-consistency" [commands..] [options]

@emmercm emmercm merged commit 4fa1e7f into main Jul 26, 2023
@emmercm emmercm deleted the emmercm/non-tty-consistency branch July 26, 2023 23:56
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make non-TTY output match TTY
2 participants