Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: "only" ROM filtering options for every "no" option #499

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 23, 2023

Fixes #489

@emmercm emmercm self-assigned this Jul 23, 2023
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/only-options" [commands..] [options]

@emmercm emmercm enabled auto-merge (squash) July 24, 2023 01:19
@codecov-commenter
Copy link

Codecov Report

Merging #499 (649aca1) into main (4a4508f) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
+ Coverage   93.40%   93.48%   +0.07%     
==========================================
  Files          73       73              
  Lines        4276     4328      +52     
  Branches      887      909      +22     
==========================================
+ Hits         3994     4046      +52     
  Misses        268      268              
  Partials       14       14              
Impacted Files Coverage Δ
src/modules/argumentsParser.ts 100.00% <100.00%> (ø)
src/modules/candidateFilter.ts 100.00% <100.00%> (ø)
src/types/options.ts 99.13% <100.00%> (+0.06%) ⬆️

@emmercm emmercm merged commit 8569246 into main Jul 24, 2023
@emmercm emmercm deleted the emmercm/only-options branch July 24, 2023 01:37
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create --only-* options for every --no-* option
2 participants