Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: memoize some archive methods for performance #487

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 19, 2023

No description provided.

@emmercm emmercm self-assigned this Jul 19, 2023
@emmercm emmercm enabled auto-merge (squash) July 19, 2023 03:08
@codecov-commenter
Copy link

Codecov Report

Merging #487 (b615bb9) into main (d18991f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #487   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          71       71           
  Lines        4146     4146           
  Branches      870      870           
=======================================
  Hits         3868     3868           
  Misses        264      264           
  Partials       14       14           
Impacted Files Coverage Δ
src/types/files/archives/archive.ts 100.00% <ø> (ø)
src/types/files/archives/rar.ts 85.71% <ø> (ø)
src/types/files/archives/sevenZip.ts 76.74% <ø> (ø)
src/types/files/archives/tar.ts 87.09% <ø> (ø)
src/types/files/archives/zip.ts 96.82% <ø> (ø)

@emmercm emmercm merged commit aec12ec into main Jul 19, 2023
@emmercm emmercm deleted the emmercm/memoize branch July 19, 2023 03:14
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/memoize" [commands..] [options]

@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants