Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: reporting on games with no ROMs #475

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Fix: reporting on games with no ROMs #475

merged 4 commits into from
Jul 12, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 12, 2023

Fixes #473

@emmercm emmercm self-assigned this Jul 12, 2023
@github-actions
Copy link

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/fix-473" [commands..] [options]

@codecov-commenter
Copy link

Codecov Report

Merging #475 (e43928e) into main (88afaac) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          71       71           
  Lines        4132     4133    +1     
  Branches      864      864           
=======================================
+ Hits         3853     3854    +1     
  Misses        265      265           
  Partials       14       14           
Impacted Files Coverage Δ
src/igir.ts 100.00% <ø> (ø)
src/modules/statusGenerator.ts 100.00% <ø> (ø)
src/modules/reportGenerator.ts 100.00% <100.00%> (ø)

@emmercm emmercm enabled auto-merge (squash) July 12, 2023 21:30
@emmercm emmercm merged commit fbbe586 into main Jul 12, 2023
@emmercm emmercm deleted the emmercm/fix-473 branch July 12, 2023 21:45
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: TypeCannot read properties of undefined (reading 'getRomsWithFiles')
2 participants