Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support MAME XML DATs #463

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Feature: support MAME XML DATs #463

merged 3 commits into from
Jun 26, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jun 26, 2023

Fixes #456

@emmercm emmercm self-assigned this Jun 26, 2023
@emmercm emmercm enabled auto-merge (squash) June 26, 2023 01:46
@codecov-commenter
Copy link

Codecov Report

Merging #463 (2c0e5bf) into main (e332503) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   93.17%   93.16%   -0.02%     
==========================================
  Files          70       70              
  Lines        4119     4126       +7     
  Branches      856      858       +2     
==========================================
+ Hits         3838     3844       +6     
- Misses        267      268       +1     
  Partials       14       14              
Impacted Files Coverage Δ
src/types/logiqx/dat.ts 94.44% <85.71%> (-0.95%) ⬇️

@emmercm emmercm merged commit c19acec into main Jun 26, 2023
@emmercm emmercm deleted the emmercm/mame-dat branch June 26, 2023 14:36
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAME XML DATs don't parse correctly
2 participants