Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: write ROM files asynchronously #36

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Update: write ROM files asynchronously #36

merged 4 commits into from
Aug 30, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 30, 2022

No description provided.

@emmercm emmercm self-assigned this Aug 30, 2022
Base automatically changed from emmercm/async-crc to main August 30, 2022 23:16
@codecov-commenter
Copy link

Codecov Report

Merging #36 (cebb995) into main (3dc8cb9) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   94.37%   94.44%   +0.06%     
==========================================
  Files          33       33              
  Lines        1423     1422       -1     
  Branches      293      293              
==========================================
  Hits         1343     1343              
  Misses         76       76              
+ Partials        4        3       -1     
Impacted Files Coverage Δ
src/modules/romScanner.ts 100.00% <ø> (ø)
src/constants.ts 100.00% <100.00%> (ø)
src/modules/romWriter.ts 89.75% <100.00%> (-0.13%) ⬇️
src/console/progressBarCLI.ts 98.14% <0.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm merged commit 98edefa into main Aug 30, 2022
@emmercm emmercm deleted the emmercm/async-write branch August 30, 2022 23:24
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants