Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: eliminate fs.promises #196

Merged
merged 8 commits into from
Dec 3, 2022
Merged

Refactor: eliminate fs.promises #196

merged 8 commits into from
Dec 3, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Dec 3, 2022

No description provided.

@emmercm emmercm self-assigned this Dec 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #196 (e3b6a18) into main (94b7561) will increase coverage by 0.00%.
The diff coverage is 91.30%.

@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   94.33%   94.34%           
=======================================
  Files          59       59           
  Lines        2985     2986    +1     
  Branches      624      624           
=======================================
+ Hits         2816     2817    +1     
  Misses        164      164           
  Partials        5        5           
Impacted Files Coverage Δ
src/polyfill/fsPoly.ts 85.98% <84.61%> (+0.13%) ⬆️
src/modules/outputCleaner.ts 94.64% <100.00%> (ø)
src/modules/reportGenerator.ts 100.00% <100.00%> (ø)
src/modules/romWriter.ts 92.36% <100.00%> (ø)
src/types/archives/zip.ts 91.25% <100.00%> (ø)
src/types/files/file.ts 93.33% <100.00%> (ø)
src/types/options.ts 99.65% <100.00%> (ø)
src/types/patches/upsPatch.ts 96.22% <100.00%> (ø)
src/types/patches/vcdiffPatch.ts 86.51% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm merged commit dea62a6 into main Dec 3, 2022
@emmercm emmercm deleted the emmercm/no-fs-promises branch December 3, 2022 16:22
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants