Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ROM patching end-to-end #160

Merged
merged 19 commits into from
Nov 5, 2022
Merged

Feature: ROM patching end-to-end #160

merged 19 commits into from
Nov 5, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Nov 4, 2022

No description provided.

@emmercm emmercm self-assigned this Nov 4, 2022
@emmercm emmercm changed the title Feature: CLI flag and tests for patch Feature: rom patching end-to-end Nov 4, 2022
@emmercm emmercm changed the title Feature: rom patching end-to-end Feature: ROM patching end-to-end Nov 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #160 (7c3d1a4) into main (325bd0e) will decrease coverage by 0.18%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   93.85%   93.66%   -0.19%     
==========================================
  Files          54       54              
  Lines        2425     2448      +23     
  Branches      502      503       +1     
==========================================
+ Hits         2276     2293      +17     
- Misses        144      149       +5     
- Partials        5        6       +1     
Impacted Files Coverage Δ
src/modules/argumentsParser.ts 100.00% <ø> (ø)
src/types/patches/ppfPatch.ts 77.41% <60.00%> (+0.37%) ⬆️
src/modules/patchScanner.ts 87.50% <66.66%> (-12.50%) ⬇️
src/types/patches/patchFactory.ts 91.66% <87.50%> (+4.16%) ⬆️
src/types/patches/bpsPatch.ts 89.87% <92.85%> (-1.34%) ⬇️
src/igir.ts 93.47% <100.00%> (-4.03%) ⬇️
src/polyfill/filePoly.ts 96.15% <100.00%> (+0.32%) ⬆️
src/types/options.ts 100.00% <100.00%> (ø)
src/types/patches/ipsPatch.ts 92.10% <100.00%> (-0.21%) ⬇️
src/types/patches/patch.ts 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm marked this pull request as ready for review November 5, 2022 03:20
@emmercm emmercm merged commit eba4a48 into main Nov 5, 2022
@emmercm emmercm deleted the emmercm/patcher-e2e branch November 5, 2022 03:21
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants