Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: write ROMs with patches #155

Merged
merged 28 commits into from
Nov 4, 2022
Merged

Feature: write ROMs with patches #155

merged 28 commits into from
Nov 4, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Nov 3, 2022

No description provided.

@emmercm emmercm self-assigned this Nov 3, 2022
@emmercm emmercm changed the title Feature: automatic ROM patching Feature: write ROMs with patches Nov 3, 2022
@emmercm emmercm marked this pull request as ready for review November 4, 2022 03:54
@codecov-commenter
Copy link

Codecov Report

Merging #155 (4a491ff) into main (e9f49b5) will increase coverage by 0.32%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   94.10%   94.43%   +0.32%     
==========================================
  Files          53       53              
  Lines        2325     2352      +27     
  Branches      487      489       +2     
==========================================
+ Hits         2188     2221      +33     
+ Misses        132      127       -5     
+ Partials        5        4       -1     
Impacted Files Coverage Δ
src/polyfill/fsPoly.ts 85.86% <0.00%> (-0.95%) ⬇️
src/types/archives/sevenZip.ts 87.50% <0.00%> (-7.96%) ⬇️
src/types/archives/tar.ts 85.71% <0.00%> (-6.60%) ⬇️
src/types/patches/patch.ts 100.00% <ø> (+11.76%) ⬆️
src/types/archives/rar.ts 86.66% <66.66%> (-13.34%) ⬇️
src/types/files/archiveEntry.ts 95.38% <81.81%> (+9.90%) ⬆️
src/types/files/file.ts 93.06% <85.71%> (-1.62%) ⬇️
src/modules/patchCandidateGenerator.ts 100.00% <100.00%> (ø)
src/modules/romWriter.ts 92.19% <100.00%> (ø)
src/types/archives/archive.ts 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm merged commit 86d1184 into main Nov 4, 2022
@emmercm emmercm deleted the emmercm/patcher branch November 4, 2022 04:16
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants