Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: prefer chdman and maxcso from $PATH #1443

Merged
merged 8 commits into from
Mar 3, 2025

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Feb 27, 2025

Fixes: #1398

@emmercm emmercm self-assigned this Feb 27, 2025
@emmercm emmercm enabled auto-merge (squash) February 27, 2025 00:04
@emmercm emmercm disabled auto-merge February 27, 2025 00:06
@emmercm emmercm enabled auto-merge (squash) February 27, 2025 00:06
@emmercm emmercm changed the title Refactor: refer chdman and maxcso from $PATH Refactor: prefer chdman and maxcso from $PATH Feb 27, 2025
@emmercm emmercm disabled auto-merge February 27, 2025 15:40
@emmercm emmercm enabled auto-merge (squash) March 3, 2025 18:33
@emmercm emmercm merged commit d3be267 into main Mar 3, 2025
51 of 53 checks passed
@emmercm emmercm deleted the emmercm/prefer-path-binary branch March 3, 2025 19:10
Copy link

github-actions bot commented Mar 3, 2025

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (5a1784b) to head (aa98949).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
+ Coverage   92.41%   92.61%   +0.19%     
==========================================
  Files         122      122              
  Lines        7636     7636              
  Branches     1737     1750      +13     
==========================================
+ Hits         7057     7072      +15     
+ Misses        553      539      -14     
+ Partials       26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use system chdman if available, fails to run due to libSDL2 dependency
1 participant