Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add {pocket} support for MSX #1415

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

dirn
Copy link
Contributor

@dirn dirn commented Jan 23, 2025

No description provided.

@dirn
Copy link
Contributor Author

dirn commented Jan 23, 2025

There is an MSX core available at https://github.com/opengateware/computer-msx.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Welcome

Thank you for your first pull request, @dirn! If you haven't yet, please familiarize yourself with Igir's contribution guidelines.

Some GitHub Actions CI workflows may not automatically run for you due to GitHub's security best practices, so a maintainer may need to manually approve the workflows to run. As a result, it is important to make sure tests pass locally before submitting a pull request to help ensure a fast review. Thank you!

Comment generated by the GitHub First Interaction workflow.

@emmercm
Copy link
Owner

emmercm commented Mar 4, 2025

Apologies for the slow response @dirn, I'll get this merged.

@emmercm emmercm merged commit 2ab09d3 into emmercm:main Mar 4, 2025
54 checks passed
Copy link

github-actions bot commented Mar 4, 2025

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.61%. Comparing base (6ee1ab7) to head (a6b4954).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files         122      122           
  Lines        7635     7635           
  Branches     1747     1734   -13     
=======================================
  Hits         7071     7071           
  Misses        539      539           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants