Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: don't delay deleting input files during writing when moving #1302

Merged
merged 6 commits into from
Aug 25, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 24, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 24, 2024
@emmercm emmercm merged commit ac28363 into emmercm/3.0.0-feature Aug 25, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/immediate-file-moves branch August 25, 2024 22:15
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 92.53731% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.76%. Comparing base (3ee18bd) to head (b6a8232).
Report is 1 commits behind head on emmercm/3.0.0-feature.

Files Patch % Lines
src/keyedMutex.ts 85.71% 3 Missing ⚠️
src/modules/candidateWriter.ts 91.66% 2 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1302      +/-   ##
=========================================================
- Coverage                  92.89%   92.76%   -0.13%     
=========================================================
  Files                        117      118       +1     
  Lines                       7441     7452      +11     
  Branches                    1806     1684     -122     
=========================================================
+ Hits                        6912     6913       +1     
- Misses                       507      538      +31     
+ Partials                      22        1      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant