Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: stop the progress multi-bar on exit #1299

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 22, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 22, 2024
@emmercm emmercm enabled auto-merge (squash) August 22, 2024 23:22
@emmercm emmercm merged commit 127dd0b into emmercm/3.0.0-feature Aug 23, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/stop-multibar-exit branch August 23, 2024 03:04
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.77%. Comparing base (16fcc6f) to head (07272ee).
Report is 1 commits behind head on emmercm/3.0.0-feature.

Files Patch % Lines
src/console/progressBarCli.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1299      +/-   ##
=========================================================
- Coverage                  92.78%   92.77%   -0.02%     
=========================================================
  Files                        117      117              
  Lines                       7402     7404       +2     
  Branches                    1788     1672     -116     
=========================================================
+ Hits                        6868     6869       +1     
- Misses                       511      534      +23     
+ Partials                      23        1      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant