Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add detection for GoodTools-style ROM names #128

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Oct 20, 2022

No description provided.

@emmercm emmercm self-assigned this Oct 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #128 (05bdb6c) into main (3fd4c5c) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   93.90%   94.06%   +0.16%     
==========================================
  Files          45       45              
  Lines        1853     1903      +50     
  Branches      389      410      +21     
==========================================
+ Hits         1740     1790      +50     
  Misses        106      106              
  Partials        7        7              
Impacted Files Coverage Δ
src/modules/argumentsParser.ts 100.00% <ø> (ø)
src/modules/candidateFilter.ts 100.00% <100.00%> (ø)
src/types/logiqx/game.ts 96.85% <100.00%> (+1.24%) ⬆️
src/types/options.ts 95.09% <100.00%> (+0.14%) ⬆️
src/types/releaseCandidate.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emmercm emmercm merged commit ea159e9 into main Oct 20, 2022
@emmercm emmercm deleted the emmercm/goodtools-detection branch October 20, 2022 02:45
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants