Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: consolidate filesize semaphore logic in DriveSemaphore #1258

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 28, 2024

No description provided.

@emmercm emmercm self-assigned this Jul 28, 2024
@emmercm emmercm enabled auto-merge (squash) July 28, 2024 23:44
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 95.77465% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.14%. Comparing base (b27b201) to head (73b19aa).

Files Patch % Lines
src/modules/scanner.ts 81.81% 2 Missing ⚠️
src/driveSemaphore.ts 98.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           emmercm/3.0.0-feature    #1258      +/-   ##
=========================================================
+ Coverage                  93.13%   93.14%   +0.01%     
=========================================================
  Files                        112      112              
  Lines                       7050     7063      +13     
  Branches                    1653     1540     -113     
=========================================================
+ Hits                        6566     6579      +13     
- Misses                       459      483      +24     
+ Partials                      25        1      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit e63c5e8 into emmercm/3.0.0-feature Jul 29, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/drive-semaphore-filesize-2 branch July 29, 2024 23:15
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant