Skip to content

Commit

Permalink
Default --merge-roms fullnonmerged
Browse files Browse the repository at this point in the history
  • Loading branch information
emmercm committed Sep 22, 2023
1 parent 4ee5583 commit f457cbd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/modules/argumentsParser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ export default class ArgumentsParser {
.map((mode) => mode.toLowerCase()),
coerce: ArgumentsParser.getLastValue, // don't allow string[] values
requiresArg: true,
default: MergeMode[MergeMode.NONMERGED].toLowerCase(),
default: MergeMode[MergeMode.FULLNONMERGED].toLowerCase(),
})

.option('filter-regex', {
Expand Down
4 changes: 2 additions & 2 deletions test/modules/argumentsParser.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ describe('options', () => {

expect(options.getSymlinkRelative()).toEqual(false);

expect(options.getMergeRoms()).toEqual(MergeMode.NONMERGED);
expect(options.getMergeRoms()).toEqual(MergeMode.FULLNONMERGED);

expect(options.getFilterRegex()).toBeUndefined();
expect(options.getFilterRegexExclude()).toBeUndefined();
Expand Down Expand Up @@ -516,7 +516,7 @@ describe('options', () => {

it('should parse "merge-roms"', () => {
expect(argumentsParser.parse(dummyCommandAndRequiredArgs).getMergeRoms())
.toEqual(MergeMode.NONMERGED);
.toEqual(MergeMode.FULLNONMERGED);
expect(() => argumentsParser.parse([...dummyCommandAndRequiredArgs, '--merge-roms', 'foobar']).getMergeRoms()).toThrow(/invalid values/i);
expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '--merge-roms', 'fullnonmerged']).getMergeRoms()).toEqual(MergeMode.FULLNONMERGED);
expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '--merge-roms', 'nonmerged']).getMergeRoms()).toEqual(MergeMode.NONMERGED);
Expand Down

0 comments on commit f457cbd

Please sign in to comment.