Chore: increase test coverage (#153)

README.md

@@ -33,7 +33,7 @@ With a large ROM collection it can be difficult to:
 
 **`igir` needs an input set of ROMs, of course!**
 
-Those ROMs can be in archives (`.001`, `.7z`, `.bz2`, `.gz`, `.rar`, `.tar.gz`, `.z01`, `.zip`, `.zipx`, and more!) or on their own. They can also contain a header or not (see [docs](docs/rom-headers.md)).
+Those ROMs can be in archives (`.001`, `.7z`, `.gz`, `.rar`, `.tar.gz`, `.z01`, `.zip`, `.zipx`, and more!) or on their own. They can also contain a header or not (see [docs](docs/rom-headers.md)).
 
 **`igir` works best with a set of DATs as well.**
 

src/polyfill/filePoly.ts

@@ -99,18 +99,6 @@ export default class FilePoly {
     return result;
   }
 
-  async readAll(): Promise<Buffer> {
-    const buffer = Buffer.alloc(this.size);
-    await util.promisify(fs.read)(
-      this.fd,
-      buffer,
-      0,
-      this.size,
-      0,
-    );
-    return buffer;
-  }
-
   async write(buffer: Buffer): Promise<number> {
     return (await util.promisify(fs.write)(this.fd, buffer)).bytesWritten;
   }

src/types/archives/sevenZip.ts

@@ -10,15 +10,15 @@ export default class SevenZip extends Archive {
   // WARNING: tar+compression doesn't work, you'll be left with a tar file output
   static readonly SUPPORTED_EXTENSIONS = [
     '.7z', // 7z
-    '.bz2', '.bzip2', // bzip2
+    // '.bz2', '.bzip2', // bzip2
     '.cab', // cab
     '.gz', '.gzip', // gzip
     '.lzma', // lzma
     '.lzma86', // lzma86
     '.pmd', // ppmd
     '.001', // split
     '.tar', '.ova', // tar
-    '.xz', // xz
+    // '.xz', // xz
     '.z', // z
     '.zip', '.z01', '.zipx', // zip
     '.zst', // zstd

src/types/options.ts

@@ -542,12 +542,6 @@ export default class Options implements OptionsProps {
     return this.help;
   }
 
-  static filterUniqueLower(array: string[]): string[] {
-    return array
-      .map((value) => value.toLowerCase())
-      .filter((val, idx, arr) => arr.indexOf(val) === idx);
-  }
-
   static filterUniqueUpper(array: string[]): string[] {
     return array
       .map((value) => value.toUpperCase())

test/modules/argumentsParser.test.ts

@@ -445,6 +445,14 @@ describe('options', () => {
     expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '--no-bad', 'true', '--no-bad', 'false']).getNoBad()).toEqual(false);
   });
 
+  it('should parse "verbose"', () => {
+    expect(argumentsParser.parse(dummyCommandAndRequiredArgs).getLogLevel()).toEqual(LogLevel.WARN);
+    expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '-v']).getLogLevel()).toEqual(LogLevel.INFO);
+    expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '--verbose']).getLogLevel()).toEqual(LogLevel.INFO);
+    expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '-vv']).getLogLevel()).toEqual(LogLevel.DEBUG);
+    expect(argumentsParser.parse([...dummyCommandAndRequiredArgs, '-vvv']).getLogLevel()).toEqual(LogLevel.DEBUG);
+  });
+
   it('should parse "help"', () => {
     expect(argumentsParser.parse(['-h']).getHelp()).toEqual(true);
     expect(argumentsParser.parse(['--help']).getHelp()).toEqual(true);

test/modules/romScanner.test.ts

@@ -41,9 +41,9 @@ describe('multiple files', () => {
   });
 
   it('some files are excluded', async () => {
-    await expect(createRomScanner(['test/fixtures/roms/**/*'], ['test/fixtures/roms/**/*.rom']).scan()).resolves.toHaveLength(41);
-    await expect(createRomScanner(['test/fixtures/roms/**/*'], ['test/fixtures/roms/**/*.rom', 'test/fixtures/roms/**/*.rom']).scan()).resolves.toHaveLength(41);
-    await expect(createRomScanner(['test/fixtures/roms/**/*'], ['test/fixtures/roms/**/*.rom', 'test/fixtures/roms/**/*.zip']).scan()).resolves.toHaveLength(32);
+    await expect(createRomScanner(['test/fixtures/roms/**/*'], ['test/fixtures/roms/**/*.rom']).scan()).resolves.toHaveLength(42);
+    await expect(createRomScanner(['test/fixtures/roms/**/*'], ['test/fixtures/roms/**/*.rom', 'test/fixtures/roms/**/*.rom']).scan()).resolves.toHaveLength(42);
+    await expect(createRomScanner(['test/fixtures/roms/**/*'], ['test/fixtures/roms/**/*.rom', 'test/fixtures/roms/**/*.zip']).scan()).resolves.toHaveLength(33);
   });
 
   it('all files are excluded', async () => {

test/modules/romWriter.test.ts

@@ -372,7 +372,7 @@ describe('zip', () => {
     [
       '**/!(*headered)/*',
       ['before.zip', 'best.zip', 'empty.zip', 'fizzbuzz.zip', 'foobar.zip', 'loremipsum.zip', 'one.zip', 'three.zip', 'two.zip', 'unknown.zip'],
-      ['patchable/before.rom', 'patchable/best.rom', 'raw/empty.rom', 'raw/fizzbuzz.nes', 'raw/foobar.lnx', 'raw/loremipsum.rom', 'raw/one.rom', 'raw/three.rom', 'raw/two.rom', 'raw/unknown.rom'],
+      ['patchable/before.rom', 'patchable/best.gz', 'raw/empty.rom', 'raw/fizzbuzz.nes', 'raw/foobar.lnx', 'raw/loremipsum.rom', 'raw/one.rom', 'raw/three.rom', 'raw/two.rom', 'raw/unknown.rom'],
     ],
     [
       '7z/*',
@@ -619,7 +619,7 @@ describe('raw', () => {
     [
       '**/!(*headered)/*',
       ['before.rom', 'best.rom', 'empty.rom', 'fizzbuzz.nes', 'foobar.lnx', 'loremipsum.rom', 'one.rom', 'three.rom', 'two.rom', 'unknown.rom'],
-      ['patchable/before.rom', 'patchable/best.rom', 'raw/empty.rom', 'raw/fizzbuzz.nes', 'raw/foobar.lnx', 'raw/loremipsum.rom', 'raw/one.rom', 'raw/three.rom', 'raw/two.rom', 'raw/unknown.rom'],
+      ['patchable/before.rom', 'patchable/best.gz', 'raw/empty.rom', 'raw/fizzbuzz.nes', 'raw/foobar.lnx', 'raw/loremipsum.rom', 'raw/one.rom', 'raw/three.rom', 'raw/two.rom', 'raw/unknown.rom'],
     ],
     [
       '7z/*',

test/polyfill/fsPoly.test.ts

@@ -48,4 +48,10 @@ describe('rmSync', () => {
     fsPoly.rmSync(file);
     await expect(fsPoly.exists(file)).resolves.toEqual(false);
   });
+
+  it('should delete an existing directory', async () => {
+    const dir = fsPoly.mkdtempSync(path.join(process.cwd(), 'temp'));
+    fsPoly.rmSync(dir);
+    await expect(fsPoly.exists(dir)).resolves.toEqual(false);
+  });
 });