-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(python): updates multiple dependencies for python #5338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LanceEa
force-pushed
the
laustin/bump-python-deps
branch
2 times, most recently
from
October 9, 2023 03:46
dbd13ba
to
f6ccb5a
Compare
rick-a-lane-ii
previously approved these changes
Oct 9, 2023
tenshinhigashi
previously approved these changes
Oct 9, 2023
haq204
reviewed
Oct 9, 2023
Updating to latest tools before updating other python deps. Signed-off-by: Lance Austin <laustin@datawire.io>
Ran `cd python && pip-compile --upgrade --allow-unsafe -q requirements.in` which bumped all the deps in `python` folder. Some notable ones: - setuptools - click - charset-normalizer - flask - werkzeug - typing-extensions - gunicorn Removed direct import of deprecated disutils because it was cause it was causing conflicts with the latest `setuptools`. Also, due to similiar issue as outlined here: pypa/pip#5247 I had to ignore uninstalling older version of packaging to allow pip to install the newer versions in base-pip container. Signed-off-by: Lance Austin <laustin@datawire.io>
Resolves open dependabot PRs and updates to latest Flask release. Normalizes project to use pyproject.toml with pip-compile for creating requirements.txt. Signed-off-by: Lance Austin <laustin@datawire.io>
Resolves open dependabot PRs and updates to latest Flask release. Normalizes project to use pyproject.toml with pip-compile for creating requirements.txt. Signed-off-by: Lance Austin <laustin@datawire.io>
Resolves open dependabot PRs and updates to latest Flask release. Normalizes project to use pyproject.toml with pip-compile for creating requirements.txt. Signed-off-by: Lance Austin <laustin@datawire.io>
Signed-off-by: Lance Austin <laustin@datawire.io>
LanceEa
force-pushed
the
laustin/bump-consul
branch
from
October 9, 2023 15:29
15cc473
to
68e7e3c
Compare
LanceEa
force-pushed
the
laustin/bump-python-deps
branch
from
October 9, 2023 15:29
f6ccb5a
to
69b3838
Compare
LanceEa
dismissed stale reviews from tenshinhigashi and rick-a-lane-ii
October 9, 2023 16:00
The base branch was changed.
haq204
approved these changes
Oct 9, 2023
apparently, merge commits still cause stacked PR's to mark reviews as stale as well. 🤷♂️ |
rick-a-lane-ii
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates a bunch of python deps and docker deps to resolve multiple open dependabot.
I also had issues with
distutils
(see commit messages for details) so the current imports in scripts were replaced since it is deprecated and recommended by the python project to move away from it. Note: I believe some of the scripts inreleng/lib
are no longer used so follow-up cleanup work should be done at some point.Bumped test Docker base images to ubuntu 23.10 and also switched the test-stats to be consistent with the others as well. Normalized each of the
Related Issues
kubernetes-client
Testing
Cleanly ran make generate and built containers. CI is green.
Checklist
CHANGELOG.md
.DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.