Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit to 0.26 #930

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Update winit to 0.26 #930

merged 4 commits into from
Dec 20, 2021

Conversation

parasyte
Copy link
Contributor

@parasyte parasyte commented Dec 3, 2021

- This has some obvious issues at the moment. First, transparent windows
  are completely broken on Windows 11. See: rust-windowing/winit#2082
  So I've completely disabled that feature for now.
- Secondly, `glium` needs an update. I'm patching it with an unreleased
  git revision to make sure things are working together.
@sourcebox
Copy link

The latest release seems to contain the fixes for the freezing dialogs on macOS. So there's finally some progress and we maybe can get rid of the winit fork now.

parasyte added a commit to parasyte/cartunes that referenced this pull request Dec 14, 2021
The following are not updated because they are blocked on
emilk/egui#930:

- `egui` and friends
- `raw-window-handle`
- `rfd`
- `winit`
- `winit_input_helper`
@parasyte
Copy link
Contributor Author

I think this is as good as I want to get it. Disabling the transparent window to avoid crashing Windows 11 seems like a fair trade.

@parasyte parasyte marked this pull request as ready for review December 14, 2021 22:15
@parasyte
Copy link
Contributor Author

There is a dependency on tts which could be updated, too. But it requires a pinned version of Rust that supports Edition 2021.

@parasyte parasyte changed the title [WIP] Update winit Update winit Dec 14, 2021
parasyte added a commit to parasyte/cartunes that referenced this pull request Dec 14, 2021
The following are not updated because they are blocked on emilk/egui#930:

- `egui` and friends
- `raw-window-handle`
- `rfd`
- `winit`
- `winit_input_helper`
@parasyte parasyte mentioned this pull request Dec 15, 2021
9 tasks
egui-winit/Cargo.toml Show resolved Hide resolved
@emilk
Copy link
Owner

emilk commented Dec 20, 2021

Closes #977

@emilk emilk changed the title Update winit Update winit to 0.26 Dec 20, 2021
@emilk emilk merged commit dd99f68 into emilk:master Dec 20, 2021
@parasyte parasyte deleted the update/winit-0.26 branch December 20, 2021 22:20
@emilk
Copy link
Owner

emilk commented Dec 25, 2021

There is a dependency on tts which could be updated, too. But it requires a pinned version of Rust that supports Edition 2021.

Updated to rust edition 2021 in #998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants