Enable rustdoc generate-link-to-definition feature on docs.rs
#5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very cool feature; I didn't know about this! Why is it opt-in and not enabled by default? |
emilk
added
docs and examples
|
Not stable and likely won't be before a long time. There are some disagreements in the rustdoc team about how we should implement this feature or whether or not we should even have this feature in the first place. "politics" |
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
…k#5030) You can see this feature in action [here](https://docs.rs/sysinfo/latest/src/sysinfo/common/system.rs.html#46) or on any of dtolnay's crates and many others. I found myself going through your project code recently on docs.rs and I was a bit sad I couldn't have this feature enabled. This should fix it at next release. :)
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
…k#5030) You can see this feature in action [here](https://docs.rs/sysinfo/latest/src/sysinfo/common/system.rs.html#46) or on any of dtolnay's crates and many others. I found myself going through your project code recently on docs.rs and I was a bit sad I couldn't have this feature enabled. This should fix it at next release. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see this feature in action here or on any of dtolnay's crates and many others. I found myself going through your project code recently on docs.rs and I was a bit sad I couldn't have this feature enabled. This should fix it at next release. :)