Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing winit feature in egui_glow #4916

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

bash
Copy link
Contributor

@bash bash commented Aug 4, 2024

Since #4849, running ./scripts/check.sh fails with:

...

error[E0277]: the trait bound `ActiveEventLoop: raw_window_handle::borrowed::HasDisplayHandle` is not satisfied
  --> crates/egui_glow/src/winit.rs:43:13
   |
43 |             event_loop,
   |             ^^^^^^^^^^ the trait `raw_window_handle::borrowed::HasDisplayHandle` is not implemented for `ActiveEventLoop`
   |
   = help: the following other types implement trait `raw_window_handle::borrowed::HasDisplayHandle`:
             raw_window_handle::borrowed::DisplayHandle<'a>
             &H
             &mut H
   = note: required for the cast from `&ActiveEventLoop` to `&dyn raw_window_handle::borrowed::HasDisplayHandle`

This PR adds the missing rwh_06 to the winit dependency (in egui-glow).

  • I have followed the instructions in the PR template

@emilk emilk added the egui_glow Relates to running egui_glow on native label Aug 5, 2024
@emilk emilk changed the title Fix glow <-> winit integration Fix missing winit feature in egui_glow Aug 5, 2024
@emilk emilk merged commit 71dbc48 into emilk:master Aug 5, 2024
19 of 20 checks passed
@bash bash deleted the fix-glow-winit branch August 5, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
egui_glow Relates to running egui_glow on native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants