Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scroll_to_* animations configurable #4305

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Make scroll_to_* animations configurable #4305

merged 5 commits into from
Jul 31, 2024

Conversation

lucasmerlin
Copy link
Collaborator

I based this on #4303, I'll rebase once that one gets merged.

@lucasmerlin lucasmerlin mentioned this pull request Apr 2, 2024
Closed
@lucasmerlin lucasmerlin force-pushed the make-scroll-animation-configurable branch 2 times, most recently from 6c0800a to c89f542 Compare May 28, 2024 18:48
@lucasmerlin lucasmerlin marked this pull request as ready for review May 28, 2024 18:51
@lucasmerlin lucasmerlin force-pushed the make-scroll-animation-configurable branch 2 times, most recently from 7bc6730 to 8c36ee7 Compare July 4, 2024 10:13
@lucasmerlin lucasmerlin force-pushed the make-scroll-animation-configurable branch from 8c36ee7 to 65b0676 Compare July 4, 2024 10:17
@lucasmerlin
Copy link
Collaborator Author

@emilk Can you have a look at this one? I think it's a useful addition and it even removes one of your TODOs!

emilk
emilk reviewed Jul 4, 2024
View reviewed changes
crates/egui/src/style.rs Outdated Show resolved Hide resolved
crates/egui/src/frame_state.rs Outdated Show resolved Hide resolved
crates/egui/src/frame_state.rs Outdated Show resolved Hide resolved
crates/egui/src/frame_state.rs Show resolved Hide resolved
crates/egui/src/style.rs Outdated Show resolved Hide resolved
crates/egui/src/style.rs Show resolved Hide resolved
crates/egui/src/style.rs Show resolved Hide resolved
crates/egui/src/style.rs Show resolved Hide resolved
@emilk emilk added egui style visuals and theming labels Jul 4, 2024
@lucasmerlin lucasmerlin force-pushed the make-scroll-animation-configurable branch 2 times, most recently from 5a93a1f to d173e54 Compare July 4, 2024 16:59
@lucasmerlin lucasmerlin force-pushed the make-scroll-animation-configurable branch from d173e54 to 902817e Compare July 4, 2024 17:09
emilk
emilk reviewed Jul 5, 2024
View reviewed changes
crates/egui/src/containers/scroll_area.rs Outdated Show resolved Hide resolved
crates/egui/src/containers/scroll_area.rs Outdated Show resolved Hide resolved
@lucasmerlin lucasmerlin requested a review from emilk July 17, 2024 17:34
@lucasmerlin lucasmerlin force-pushed the make-scroll-animation-configurable branch from 1e4e873 to b393b71 Compare July 17, 2024 17:35
emilk
emilk approved these changes Jul 31, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk changed the title Make scroll_to_* animations configurable Make scroll_to_* animations configurable Jul 31, 2024
@emilk emilk merged commit c5bea31 into emilk:master Jul 31, 2024
19 checks passed
@rustbasic rustbasic mentioned this pull request Jul 31, 2024
Closed
@rustbasic rustbasic mentioned this pull request Sep 14, 2024
Closed
@CrazyboyQCD CrazyboyQCD mentioned this pull request Sep 26, 2024
Closed
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
@lucasmerlin @486c
Make scroll_to_* animations configurable (emilk#4305)
e13fe04 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes emilk#4295

I based this on emilk#4303, I'll rebase once that one gets merged.
@rustbasic rustbasic mentioned this pull request Oct 26, 2024
Open
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@lucasmerlin @hacknus
Make scroll_to_* animations configurable (emilk#4305)
f9648df 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes emilk#4295

I based this on emilk#4303, I'll rebase once that one gets merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui style visuals and theming
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add some way to specify whether scroll_to_rect etc.. should be animated
2 participants
@lucasmerlin @emilk