Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem clicking the edge of a TextEdit #4272

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented Mar 30, 2024

@emilk emilk added bug Something is broken egui labels Mar 30, 2024
@@ -1113,8 +1113,6 @@ impl Context {
changed: false,
};

let clicked_elsewhere = res.clicked_elsewhere();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug was that this was called too early.

@emilk emilk merged commit a7c5eb4 into master Mar 30, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-text-edit-focus branch March 30, 2024 09:22
@emilk emilk changed the title Fix bug in determining wether to remove focus from a widget Fix problem clicking the edge of a TextEdit Apr 2, 2024
@emilk emilk mentioned this pull request Apr 2, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextEdit partially ignore clicks when they are not centred enough
1 participant