Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve panic message in egui-wgpu when failing to create buffers #3986

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Improve panic message in egui-wgpu when failing to create buffers #3986

merged 2 commits into from
Feb 10, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Feb 6, 2024 •
edited
Loading

Example:

thread 'main' panicked at 'Failed to create staging buffer for vertex data. Vertex count: 10 011 232. Required vertex buffer size: 200 224 640. Actual size 349 450 240 and capacity: 349 450 240 (bytes)

@emilk emilk added the egui-wgpu label Feb 6, 2024
@emilk emilk requested a review from Wumpf February 6, 2024 08:48
@emilk emilk mentioned this pull request Feb 6, 2024
Closed
@emilk emilk merged commit 800eff6 into master Feb 10, 2024
35 checks passed
@emilk emilk deleted the emilk/improve-panic-message-in-egui-wgpu branch February 10, 2024 08:15
emilk added a commit that referenced this pull request Feb 10, 2024
@emilk
Improve panic message in egui-wgpu when failing to create buffers (#3986
1fe0f24 
)

Example:

> thread 'main' panicked at 'Failed to create staging buffer for vertex
data. Vertex count: 10 011 232. Required vertex buffer size:
200 224 640. Actual size 349 450 240 and capacity: 349 450 240 (bytes)
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@emilk @hacknus
Improve panic message in egui-wgpu when failing to create buffers (em…
50064b3 
…ilk#3986)

Example:

> thread 'main' panicked at 'Failed to create staging buffer for vertex
data. Vertex count: 10 011 232. Required vertex buffer size:
200 224 640. Actual size 349 450 240 and capacity: 349 450 240 (bytes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Awaiting requested review from Wumpf Wumpf is a code owner

Assignees
No one assigned
Labels
egui-wgpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emilk