-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix high CPU usage on Windows when app is minimized #3985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to give your PR descriptive titles. The PR title is what ends up in the changelog!
rustbasic
changed the title
patch #3982
Windows: High CPU Usage when minimized : issue #3982
Feb 6, 2024
emilk
approved these changes
Feb 6, 2024
emilk
changed the title
Windows: High CPU Usage when minimized : issue #3982
Fix high CPU usage on Windows when app is minimized
Feb 6, 2024
Thanks! |
emilk
pushed a commit
that referenced
this pull request
Sep 1, 2024
Fix: The viewport stops working when the program is minimized. Fix: Logically, the weird parts have been normalized. **Issue :** The viewport stops working when the program is minimized. * Related #3321 * Related #3877 * Related #3985 * Closes #3972 * Closes #4772 * Related #4832 * Closes #4892 **Solution :** When `request_redraw()` is performed in Minimized state, the occasional screen tearing phenomenon has disappeared. ( Probably expected to be the effect of #4814 ) To address the issue of the `Immediate Viewport` not updating in Minimized state, we can call `request_redraw()`.
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
Fix: The viewport stops working when the program is minimized. Fix: Logically, the weird parts have been normalized. **Issue :** The viewport stops working when the program is minimized. * Related emilk#3321 * Related emilk#3877 * Related emilk#3985 * Closes emilk#3972 * Closes emilk#4772 * Related emilk#4832 * Closes emilk#4892 **Solution :** When `request_redraw()` is performed in Minimized state, the occasional screen tearing phenomenon has disappeared. ( Probably expected to be the effect of emilk#4814 ) To address the issue of the `Immediate Viewport` not updating in Minimized state, we can call `request_redraw()`.
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
Fix: The viewport stops working when the program is minimized. Fix: Logically, the weird parts have been normalized. **Issue :** The viewport stops working when the program is minimized. * Related emilk#3321 * Related emilk#3877 * Related emilk#3985 * Closes emilk#3972 * Closes emilk#4772 * Related emilk#4832 * Closes emilk#4892 **Solution :** When `request_redraw()` is performed in Minimized state, the occasional screen tearing phenomenon has disappeared. ( Probably expected to be the effect of emilk#4814 ) To address the issue of the `Immediate Viewport` not updating in Minimized state, we can call `request_redraw()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3982