Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix high CPU usage on Windows when app is minimized #3985

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

rustbasic
Copy link
Contributor

@rustbasic rustbasic commented Feb 6, 2024

Closes #3982

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to give your PR descriptive titles. The PR title is what ends up in the changelog!

crates/eframe/src/native/run.rs Outdated Show resolved Hide resolved
@rustbasic rustbasic changed the title patch #3982 Windows: High CPU Usage when minimized : issue #3982 Feb 6, 2024
@emilk emilk added the eframe Relates to epi and eframe label Feb 6, 2024
@emilk emilk changed the title Windows: High CPU Usage when minimized : issue #3982 Fix high CPU usage on Windows when app is minimized Feb 6, 2024
@emilk emilk added the performance Lower CPU/GPU usage (optimize) label Feb 6, 2024
@emilk
Copy link
Owner

emilk commented Feb 6, 2024

Thanks!

@emilk emilk merged commit 68eb3db into emilk:master Feb 6, 2024
20 of 21 checks passed
@rustbasic rustbasic deleted the patch5 branch February 8, 2024 11:56
emilk pushed a commit that referenced this pull request Sep 1, 2024
Fix: The viewport stops working when the program is minimized.   

Fix: Logically, the weird parts have been normalized.
                                                               
**Issue :**
The viewport stops working when the program is minimized.
                         
* Related #3321
* Related #3877
* Related #3985
* Closes #3972
* Closes #4772
* Related #4832 
* Closes #4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of #4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
Fix: The viewport stops working when the program is minimized.   

Fix: Logically, the weird parts have been normalized.
                                                               
**Issue :**
The viewport stops working when the program is minimized.
                         
* Related emilk#3321
* Related emilk#3877
* Related emilk#3985
* Closes emilk#3972
* Closes emilk#4772
* Related emilk#4832 
* Closes emilk#4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of emilk#4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Fix: The viewport stops working when the program is minimized.   

Fix: Logically, the weird parts have been normalized.
                                                               
**Issue :**
The viewport stops working when the program is minimized.
                         
* Related emilk#3321
* Related emilk#3877
* Related emilk#3985
* Closes emilk#3972
* Closes emilk#4772
* Related emilk#4832 
* Closes emilk#4892
**Solution :**
When `request_redraw()` is performed in Minimized state, the occasional
screen tearing phenomenon has disappeared.
( Probably expected to be the effect of emilk#4814 )
To address the issue of the `Immediate Viewport` not updating in
Minimized state, we can call `request_redraw()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eframe Relates to epi and eframe performance Lower CPU/GPU usage (optimize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: High CPU Usage when minimized
2 participants