Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColorImage::from_gray_iter #3536

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Add ColorImage::from_gray_iter #3536

merged 4 commits into from
Feb 20, 2024

Conversation

wangxiaochuTHU
Copy link
Contributor

@wangxiaochuTHU wangxiaochuTHU commented Nov 8, 2023

Add an alternative method for creating a [ColorImage] that accepts Iterator as the argument. It can be useful when &[u8] is not available but the iterator is.

Add an alternative method for creating a [`ColorImage`] that accepts `Iterator` as the argument. It can be useful when `&[u8]` is not available but the iterator is.
crates/epaint/src/image.rs Outdated Show resolved Hide resolved
@emilk emilk added the epaint label Nov 10, 2023
@emilk emilk changed the title Add a method to create a [ColorImage] Add ColorImage:: from_gray_iter Nov 10, 2023
@emilk emilk added the egui label Nov 10, 2023
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
crates/epaint/src/image.rs Outdated Show resolved Hide resolved
@emilk emilk changed the title Add ColorImage:: from_gray_iter Add ColorImage::from_gray_iter Feb 16, 2024
@emilk
Copy link
Owner

emilk commented Feb 16, 2024

please fix the compilation if you want this merged

@emilk emilk marked this pull request as draft February 16, 2024 09:55
@wangxiaochuTHU wangxiaochuTHU marked this pull request as ready for review February 19, 2024 09:02
@emilk emilk merged commit ca8eeb8 into emilk:master Feb 20, 2024
19 checks passed
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Add an alternative method for creating a [`ColorImage`] that accepts
`Iterator` as the argument. It can be useful when `&[u8]` is not
available but the iterator is.

<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review you PR, but my time is limited!
-->

---------

Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants