Add methods to load/store TextEditState undoer
#3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feels awful, @emilk why does this have to be an Arc? Should the Arc be replaced with a new one when set_undoer is called, or should it just replace the undoer inside the Arc? Closes emilk#3436
|
@emilk what are your thoughts on this? It's marked as draft just because I'm not sure what the final API design for this should be. |
|
Looks good to me. Why is it an
|
|
Alright. I primarily wanted to use this to save and restore the undoer state in response to user input, so cloning the inner part of the |
emilk
approved these changes
Jan 7, 2024
emilk
changed the title
TextEditState undoer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels awful, @emilk why does this have to be an Arc?
Should the Arc be replaced with a new one when set_undoer is called, or should it just replace the undoer inside the Arc?
Closes #3436