Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems with tabs in text #3355

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Fix problems with tabs in text #3355

merged 3 commits into from
Sep 18, 2023

Conversation

emilk
Copy link
Owner

@emilk emilk commented Sep 18, 2023 •
edited
Loading

The problem was the ascent was not correct for tab glyphs (nor for thin-space). I fixed it by removing it from GlyphInfo and keeping it in the font itself.

@emilk emilk added bug Something is broken text Problems related to text egui epaint labels Sep 18, 2023
@emilk emilk merged commit 8073ca6 into master Sep 18, 2023
35 of 38 checks passed
@emilk emilk deleted the emilk/tab-text-layout branch September 18, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something is broken egui epaint text Problems related to text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labels with tabs-only text don't allocate space
1 participant
@emilk