Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing menu_image_button to use ImageButton builder #3288

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Changing menu_image_button to use ImageButton builder #3288

merged 1 commit into from
Sep 4, 2023

Conversation

v-kat
Copy link
Contributor

@v-kat v-kat commented Aug 29, 2023 •
edited
Loading

I'm changing menu_image_button to allow passing in an ImageButton so that I can modify the frame of the passed in ImageButton. It's a breaking API change but I kept the shorthand ui version the same.

@v-kat v-kat marked this pull request as ready for review August 30, 2023 16:11
@abey79 abey79 added the egui label Aug 31, 2023
emilk
emilk approved these changes Sep 4, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@emilk emilk changed the title Changing menu_image_button to use ImageButton builder Changing menu_image_button to use ImageButton builder Sep 4, 2023
@emilk emilk merged commit 59235ff into emilk:master Sep 4, 2023
18 of 19 checks passed
@v-kat v-kat mentioned this pull request Nov 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-kat @emilk @abey79