Add option to truncate text at wrap width #3244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
emilk
changed the title
elide option to truncate text at wrap width
emilk
changed the title
elide option to truncate text at wrap width
emilk
changed the title
abey79
approved these changes
Aug 14, 2023
4 tasks
abey79
added a commit
to rerun-io/rerun
that referenced
this pull request
Aug 16, 2023
### What As the title says. Also fixes `StoreHub::remove_recording_id()` to only change selection _if_ the currently selected recording is being removed (otherwise the selection remains unchanged). TODO: - [x] blocked on emilk/egui#3244 <img width="1293" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/e2272633-86bb-423c-935d-c7dd8e68fe67"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2976) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2976) - [Docs preview](https://rerun.io/preview/pr%3Aantoine%2Frecording-close-button/docs) - [Examples preview](https://rerun.io/preview/pr%3Aantoine%2Frecording-close-button/examples) --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now easily elide text that doesn't fit a certain max width.
This is done using
Label::new(long_text).truncate(true). The text will be truncated to fit the max width of the parentUi, and the…ellipsis will replace the omitted text. The text may get truncated in the middle of a word. When hovering a label with elided text, the full non-elided text will be shown in a tool-tip.You can use the options in
TextWrappingfor finer control.TextWrapping::max_rows == 0will now output zero rows. Useusize::MAXto set no limit.TextWrapping::max_rowswill now count total rows (not rows per paragraph, as previous).ADDED:
Galley::elided, to see if the text layout elided the input textMost of the implementation had already be done by @awaken1ng in #1291
Future work
There are normally three modes of elision that can be desired:
… jumps over the lazy dogThe quick … the lazy dogThe quick brown fox jumps…This PR only adds support for the latter kind.
It would also be good to have an option to only omit whole words, never breaking them.
Finally, being able to set the truncate character to a string (e.g.
…with a leading space) would be nice.