Add Memory::area_rect
#3161
Merged
Add Memory::area_rect
#3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosti007
force-pushed
the
memory-expose-area-size
branch
from
abf5f68
to
8e812a6
Compare
tosti007
changed the title
area::State in Memoryarea::State's Rect in Memory
tosti007
force-pushed
the
memory-expose-area-size
branch
3 times, most recently
from
b860990
to
6c693a6
Compare
emilk
approved these changes
Aug 9, 2023
crates/egui/src/memory.rs
Outdated
| @@ -487,6 +487,11 @@ impl Memory { | |||
| pub fn reset_areas(&mut self) { | |||
| self.areas = Default::default(); | |||
| } | |||
|
|
|||
| /// Obtain the previous area rect of a window. | |||
| pub fn window_rect(&self, id: impl Into<Id>) -> Option<Rect> { | |||
There was a problem hiding this comment.
It would be great to link to this function from the docs of Window and Area
tosti007
force-pushed
the
memory-expose-area-size
branch
2 times, most recently
from
9145473
to
eca56ee
Compare
|
I added the doc-links on |
tosti007
commented
Aug 16, 2023
| @@ -21,6 +21,9 @@ use super::*; | |||
| /// ui.label("Hello World!"); | |||
| /// }); | |||
| /// # }); | |||
| /// ``` | |||
There was a problem hiding this comment.
Also did a drive-by fix here.
tosti007
force-pushed
the
memory-expose-area-size
branch
from
eca56ee
to
c5f0cdb
Compare
emilk
approved these changes
Aug 16, 2023
emilk
changed the title
area::State's Rect in Memoryarea::State's Rect in Memory
emilk
changed the title
area::State's Rect in Memoryarea::State's Rect in Memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way of obtaining any information on windows from
Memory, even though this is in fact stored in there. This PR exposes thearea::Statestruct as public and adds a function to obtain saidStatefor a window.