-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return TableOutput
struct from TableBuilder::body()
#3119
base: master
Are you sure you want to change the base?
Conversation
TableOutput
struct from TableBuilder::body()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a good start!
I'm not sure why the CI isn't kicking in. Perhaps try merging in latest |
7dcddfe
to
b2c4b35
Compare
I just finished a rebase on top of master, and it seems to require approval from a maintainer to run the CI. |
264e6b9
to
760dcf3
Compare
Looks good, except for the missing newline |
bump! I cannot commit my suggested change |
also needs merge of |
Currently it appears to be impossible, or very difficult, to receive information about the table that will be drawn to the window. This PR adds a barebones solution to this by returning a
TableOutput
struct fromfn body()
which describes the basic details about the header and the content body of the table.I'm ok with spending the extra time to expand this further to cover more of the data about the table, such as being able to return values from the header and body functions, or being able to specify the sense on them. However, I want to verify this is the preferred way of doing this beforehand.