Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return TableOutput struct from TableBuilder::body() #3119

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KYovchevski
Copy link
Contributor

Currently it appears to be impossible, or very difficult, to receive information about the table that will be drawn to the window. This PR adds a barebones solution to this by returning a TableOutput struct from fn body() which describes the basic details about the header and the content body of the table.

I'm ok with spending the extra time to expand this further to cover more of the data about the table, such as being able to return values from the header and body functions, or being able to specify the sense on them. However, I want to verify this is the preferred way of doing this beforehand.

@KYovchevski KYovchevski changed the title Add TableOutput struct Return TableOutput struct from TableBuilder::body() Jun 28, 2023
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a good start!

@emilk
Copy link
Owner

emilk commented Aug 9, 2023

I'm not sure why the CI isn't kicking in. Perhaps try merging in latest master and see if it helps?

@KYovchevski
Copy link
Contributor Author

I'm not sure why the CI isn't kicking in. Perhaps try merging in latest master and see if it helps?

I just finished a rebase on top of master, and it seems to require approval from a maintainer to run the CI.

@tosti007 tosti007 force-pushed the table-output-struct branch from 264e6b9 to 760dcf3 Compare August 16, 2023 08:13
@emilk
Copy link
Owner

emilk commented Sep 18, 2023

Looks good, except for the missing newline

@emilk
Copy link
Owner

emilk commented Jan 7, 2024

bump! I cannot commit my suggested change

@emilk
Copy link
Owner

emilk commented Jan 7, 2024

also needs merge of master

@emilk emilk marked this pull request as draft February 16, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants