Fix: request_repaint_after works even when called from background thread
#2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 92dde25.
|
@emilk is there any way you could cut a release with this fix please? We're having issues with our build infra + git dependencies so it would be very helpful if we could just point at a released version. Thanks for all your work on this awesome library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2674
The callback installed with
Context::set_request_repaint_callbackis now given aRequestRepaintInfowhich contains anafter: std::time::Durationspecifying how long to wait until repainting. It is up to integration to heed this.With
eframe, both web and native now supports requesting repaints, with delay, from background threads and tasks.