Menu State rect now uses menu frame rect instead of contents rect. #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a menu is opened near the edge of screen, the rect of the
add_contentsresponse is always> cursor_posas expected during regular function, but not when the area moves itself to accommodate the screen edges.As a solution I made the menu_state rect be the same as the menu frame, which fixes the issue. I am unsure if there is a better solution, such as making the
add_contentsaware that their parent has been moved.I also removed a redundant call that set the menu_state rect a second time unnecessarily as it had already been set during
MenuState::show.Closes #2862 .