Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose the value/satuation panel of the color picker #2727

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

IVAN-MK7
Copy link
Contributor

Swaps the hsva's saturation and value positions when used as arguments when calling the color_slider_2d, in order to make it display the color mix in a way more common in the image alteration softwares space.
color_slider_2d(ui, v, s, |v, s| HsvaGamma { s, v, ..opaque }.into())
to
color_slider_2d(ui, s, v, |s, v| HsvaGamma { s, v, ..opaque }.into())

image

Closes #2681.

@IVAN-MK7 IVAN-MK7 marked this pull request as ready for review February 12, 2023 16:58
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilk emilk merged commit e9d869c into emilk:master Feb 28, 2023
@IVAN-MK7 IVAN-MK7 deleted the hsva_color_slider_2d_orientation branch February 28, 2023 20:28
@emilk emilk added the egui label Apr 18, 2023
@emilk emilk changed the title hsva color_slider_2d orientation change Tramspose the value/satuation panel of the color picker Apr 18, 2023
@emilk emilk changed the title Tramspose the value/satuation panel of the color picker Transpose the value/satuation panel of the color picker Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker is not standard
2 participants