Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Mesh::split_to_u16 #2459

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Fix bug in Mesh::split_to_u16 #2459

merged 4 commits into from
Dec 15, 2022

Conversation

emilk
Copy link
Owner

@emilk emilk commented Dec 15, 2022

Builds on #2451 (I failed to push more commits onto that branch)
Closes #2458

Please try it out @pum-purum-pum-pum

@emilk emilk mentioned this pull request Dec 15, 2022
Closed
@emilk emilk changed the title Emilk/fix u16 split fix bug in Mesh::split_to_u16 Dec 15, 2022
@emilk emilk changed the title fix bug in Mesh::split_to_u16 Fix bug in Mesh::split_to_u16 Dec 15, 2022
@pum-purum-pum-pum
Copy link
Contributor

Yeah it's correct, thanks for clarifying!
Patched the old version I'm on -- it works

@emilk emilk merged commit ea5c948 into master Dec 15, 2022
@emilk emilk deleted the emilk/fix-u16-split branch December 15, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split_to_u16 produces mesh that doesn't pass validity check
2 participants
@emilk @pum-purum-pum-pum