Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render the \r (Carriage Return) character, because it sucks #2452

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Don't render the \r (Carriage Return) character, because it sucks #2452

merged 3 commits into from
Dec 14, 2022

Conversation

emilk
Copy link
Owner

@emilk emilk commented Dec 14, 2022 •
edited
Loading

It is the textual equivalent of coriander a stubbed toe

@Wumpf Wumpf self-requested a review December 14, 2022 13:56
Wumpf
Wumpf requested changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks great but can't let that PR description stand this way

@emilk emilk merged commit 4e8341d into master Dec 14, 2022
@emilk emilk deleted the emilk/ignore-cr branch December 14, 2022 14:15
@Kryptos-FR Kryptos-FR mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf