fix all clippy lints and remove them from allow list in cranky #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the majority of the lints were already fixed in 5093b67 I will leave type complexity lint alone. It requires naming a bunch of closures types in plot module which i have no idea about. |
Wumpf
approved these changes
Dec 11, 2022
emilk
added a commit
that referenced
this pull request
Dec 12, 2022
* Revert "fix all clippy lints and remove them from allow list in cranky (#2419)" This reverts commit 930ef2d. * Explain the cranky lints better * Add Color32::gamma_multiply * Remove unused pub use * Remove non-existing crate category * Improve color test with more lines * Improve the look of thin lines, making them look weaker Before they looked were too strong for the thickness. * Use asserts for shader compilations * Update changelogs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a new version has been published, its better to clean up clippy lints before any other major pull requests.