Improve plot grid appearance #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-nie
commented
Dec 8, 2022
crates/egui/src/widgets/plot/mod.rs
Outdated
| @@ -331,6 +332,7 @@ impl Plot { | |||
| show_background: true, | |||
| show_axes: [true; 2], | |||
| grid_spacers: [log_grid_spacer(10), log_grid_spacer(10)], | |||
| sharp_grid_lines: false, | |||
There was a problem hiding this comment.
We can discuss whether to make this the default or not. I personally don't mind the slight aliasing.
There was a problem hiding this comment.
I think I prefer it on (as is currently the case)
There was a problem hiding this comment.
Now enabled by default in 848310d.
emilk
reviewed
Dec 9, 2022
crates/egui/src/widgets/plot/mod.rs
Outdated
Comment on lines
1323
to
1324
| // Sort the axes by contrast so that those with higher contrast are drawn in front. | ||
| axes_shapes.sort_by(|(_, contrast1), (_, contrast2)| contrast1.total_cmp(contrast2)); |
There was a problem hiding this comment.
maybe "strength" is a slightly better word?
emilk
approved these changes
Dec 9, 2022
CHANGELOG.md
Outdated
| @@ -38,6 +38,7 @@ NOTE: [`epaint`](crates/epaint/CHANGELOG.md), [`eframe`](crates/eframe/CHANGELOG | |||
| * Tooltips are only shown when mouse pointer is still ([#2263](https://github.com/emilk/egui/pull/2263)). | |||
| * Make it slightly easier to click buttons ([#2304](https://github.com/emilk/egui/pull/2304)). | |||
| * `egui::color` has been renamed `egui::ecolor` ([#2399](https://github.com/emilk/egui/pull/2399)). | |||
| * Improved plot grid appearance ([#2412](https://github.com/emilk/egui/pull/2412)). | |||
There was a problem hiding this comment.
Please move to the ## Unreleased section!
crates/egui/src/widgets/plot/mod.rs
Outdated
| @@ -331,6 +332,7 @@ impl Plot { | |||
| show_background: true, | |||
| show_axes: [true; 2], | |||
| grid_spacers: [log_grid_spacer(10), log_grid_spacer(10)], | |||
| sharp_grid_lines: false, | |||
There was a problem hiding this comment.
I think I prefer it on (as is currently the case)
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
emilk
reviewed
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2411.
Before/After
