Fixed color edit popup going outside the screen #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I can confirm that this fixes the issue I had https://discord.com/channels/900275882684477440/904461220592119849/1039604520117882941:
The pickers still are very close to the edge, maybe a small amount of padding would look better? |
emilk
reviewed
Nov 9, 2022
emilk
approved these changes
Nov 11, 2022
|
Hm, Window is already constrained to the screen bounds and I don't see a reason why anyone would not want that. |
|
@ItsEthra yup, maybe Let's do that in a separate PR though so we don't break something else whilst fixing this. |
emilk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Fixed color edit popup going outside the screen * Added option to constrain areas * Constrain color picker area * Constrain popups * Updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.