Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed color edit popup going outside the screen #2270

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

ItsEthra
Copy link
Contributor

@ItsEthra ItsEthra commented Nov 9, 2022

No description provided.

@jakobhellermann
Copy link

Thanks! I can confirm that this fixes the issue I had https://discord.com/channels/900275882684477440/904461220592119849/1039604520117882941:

right
bottom

The pickers still are very close to the edge, maybe a small amount of padding would look better?

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking your time to do this!

Please add a line in CHANGELOG.md about the new Area::constrain feature (and maybe add that feature to Window as well?) and I'll merge this!

@ItsEthra
Copy link
Contributor Author

Hm, Window is already constrained to the screen bounds and I don't see a reason why anyone would not want that.

@emilk
Copy link
Owner

emilk commented Nov 11, 2022

@ItsEthra yup, maybe constrain should be on by default.

Let's do that in a separate PR though so we don't break something else whilst fixing this.

@emilk emilk merged commit f790e24 into emilk:master Nov 11, 2022
emilk pushed a commit that referenced this pull request Dec 2, 2022
* Fixed color edit popup going outside the screen

* Added option to constrain areas

* Constrain color picker area

* Constrain popups

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants