Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse delta from DeviceEvent #1614
base: master
Are you sure you want to change the base?
Mouse delta from DeviceEvent #1614
Changes from all commits
e401fa4
183b134
a65acd1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe touch screens should set
motion
too?Better yet:
RawInput
could havemotion: Option<Vec2>
and thenInputState::begin_frame
would use it if set, or else fall back to the pointer delta. That way it will work correctly for all existing backends.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not
egui
s responsibility to have platform-specific code like this. Instead it is up to the integrations to feedegui
with the correct input.In this case the winit backend should feed different data than the web backend. Other integrations needs to do whats right for them.
So if this is called
mtion_delta
then it should probably useself.ctx.input().pointer.motion()
regardless of what the compilation target is.Also: 'wasm" doesn't mean "web". There are egui users who run egui in wasmtime on desktop.