Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ComboBox::icon() #1405

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add ComboBox::icon() #1405

merged 2 commits into from
Mar 23, 2022

Conversation

4JX
Copy link
Contributor

@4JX 4JX commented Mar 22, 2022 •
edited
Loading

Inspired by and based on the commit for CollapsingHeader::icon(). Decided to take the whole &Ui rather than &Painter for flexibility.

emilk
emilk requested changes Mar 23, 2022
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Would it perhaps make sense to also give a opened: bool argument, so users can paint different icons when it is opened and closed?

egui/src/containers/combo_box.rs Outdated Show resolved Hide resolved
@4JX
Copy link
Contributor Author

4JX commented Mar 23, 2022

Cool! Would it perhaps make sense to also give a opened: bool argument, so users can paint different icons when it is opened and closed?

Seems like a good idea, added in the latest commit

@4JX 4JX requested review from emilk March 23, 2022 19:57
@emilk emilk merged commit dd96990 into emilk:master Mar 23, 2022
@emilk
Copy link
Owner

emilk commented Mar 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4JX @emilk