Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageSource::Bytes docs should mention URIs are used for format detection #3363

Closed
xTibor opened this issue Sep 19, 2023 · 1 comment · Fixed by #3402
Closed

ImageSource::Bytes docs should mention URIs are used for format detection #3363

xTibor opened this issue Sep 19, 2023 · 1 comment · Fixed by #3402
Labels
bug Something is broken
Milestone

Comments

@xTibor
Copy link
Contributor

xTibor commented Sep 19, 2023

Describe the bug
The new ImageSource::Bytes docs does not mention providing URIs are mandatory and used for format detection. This is kinda a significant detail.

Based on the current docs one might think these URIs are there just for error reporting and egui is using some kind of format probing on the provided data instead. At least that's what I first thought trying out the new API.

@xTibor xTibor added the bug Something is broken label Sep 19, 2023
@emilk emilk added this to the 0.23.0 milestone Sep 20, 2023
@emilk
Copy link
Owner

emilk commented Sep 27, 2023

Good point - will fix momentarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants