Bug 1502185 - Don't allow auto in grid line names. r=mats

See w3c/csswg-drafts#2856. Differential Revision: https://phabricator.services.mozilla.com/D9882
emilio · Nov 5, 2018 · 34feb3a · 34feb3a
1 parent 77967ff
commit 34feb3a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/components/style/values/generics/grid.rs b/components/style/values/generics/grid.rs
@@ -120,7 +120,9 @@ impl Parse for GridLine<specified::Integer> {
                 if val_before_span || grid_line.ident.is_some() {
                     return Err(location.new_custom_error(StyleParseErrorKind::UnspecifiedError));
                 }
-                grid_line.ident = Some(CustomIdent::from_ident(location, &name, &[])?);
+                // NOTE(emilio): `span` is consumed above, so we only need to
+                // reject `auto`.
+                grid_line.ident = Some(CustomIdent::from_ident(location, &name, &["auto"])?);
             } else {
                 break;
             }

diff --git a/components/style/values/specified/grid.rs b/components/style/values/specified/grid.rs
@@ -95,7 +95,7 @@ pub fn parse_line_names<'i, 't>(
         while let Ok((loc, ident)) = input.try(|i| -> Result<_, CssParseError<()>> {
             Ok((i.current_source_location(), i.expect_ident_cloned()?))
         }) {
-            let ident = CustomIdent::from_ident(loc, &ident, &["span"])?;
+            let ident = CustomIdent::from_ident(loc, &ident, &["span", "auto"])?;
             values.push(ident);
         }