-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump mermaid from 9.2.2 to 11.4.1 #365
base: master
Are you sure you want to change the base?
Conversation
@emilhe - just checking is there anything I need to do to progress this? |
How do you build the package? I tried bumping from 9.2.2 to 10.4.0 but no joy. |
@ploncker assuming you have setup your Python environmen and installed the relevant packages with
in you terminal to build the project. Next, if you want to build the Python package, run
You can see the build process in the pipeline definition. |
Getting a "path requested is not valid" error now, related to async-null.js. Which is what you got above. So that's at least reproducible. Why would this be being left out of the 'dash_extensions'? You mention that the Mermaid component is a light wrapper of react-mermaid2, which makes it possible to draw flow diagrams. File "blah/blah/python3.10/site-packages/dash/_validate.py", line 382, in validate_js_path |
Summary of Changes
Updated the mermaid version, based on laurent22/joplin#8728, to access new chart types.
Reason for Changes
See issue: No diagram type detected for text "quadrantChart..."
Testing
I've run into some build issues, so haven't been able to test.
One test could be: