Improve battery level #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change algorithm to be based on charge current when charging and use different voltage levels for charge and discharge. reduce termination current to allow higher top of charge voltage.
scale limits to keep battery level percentage approximately the same for all 3 input current limits and when not connected.
|
For battery lifetime I would suggest not charging up to 4.2. Do we have a reason to do so? |
|
I've not actually changed the target voltage, just reduced the termination current. my comment is wrong, I misread issue #175 where the old max voltage used in the battery level api is 4.1V. While testing this change I saw 4.2V as the top of charge, so assumed the termination current change was allowing it to reach 4.2V. The PMIC defaults to 4.2V and we are not changing it, but we can if a lower target charge voltage is what we want. |
npentrel
approved these changes
Jul 2, 2024
|
I'm going to merge this in and if we want to change the target charge voltage, we can do it as a separate change. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes issue #83
rework the battery level algorithm to be use different values for discharge and charge states and in the charge state use charge current profiles based on input current limits to calculate SOC. Reduce the charge termination current to 64mA to allow battery to charge to 4.2V.