-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedule/feeds: make json feed schema compatible #1612
base: main
Are you sure you want to change the base?
Conversation
d94e2f3
to
d70ab38
Compare
also add request argument to show the old-style json schedule
174dd59
to
550b857
Compare
9832e92
to
ee12ce8
Compare
ee12ce8
to
c2e1603
Compare
I re-set this to draft state because the machine i used to test this on is no longer available, and i don't have any other machines running docker atm |
e8ee349
to
d41b13b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good inclusion I think, thanks!
I wonder if we should be generating the data for this in one place though, given this is all the same stuff that's in the frab xml exporter. Removes the possiblity of accidentally having the two not agree!
apps/schedule/schedule_json.py
Outdated
} | ||
for name in (proposal.published_names or proposal.user.name).split(",") | ||
], | ||
"recording_license": "CC BY-SA 3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're at 4.0 now - see #1643
Would probably be good to set this in a single place. I expect a constant or config item would be fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would propose i'll create a separate PR for that
…le/{year}.frab.{json,xml}
No description provided.