Push notifications #1418
Draft
Push notifications #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't looked through super closely, but looks great and could also fit really well alongside APNS push notifications for apple wallet tickets... |
jellybob
force-pushed
the
push-notifications
branch
from
e582fb2 to
10df98f
Compare
|
This is probably in a reasonable state for testing now. No notifications are being queued other than those requested with the test button, but I think there's some value in wider testing of that basic functionality given how finicky WebPush has been for me so far. You'll need to set |
jellybob
force-pushed
the
push-notifications
branch
from
4d67261 to
dfdc6c1
Compare
jellybob
commented
Apr 21, 2024
apps/notifications/jobs.py
Outdated
|
|
||
|
|
||
| @scheduled_task(minutes=15) | ||
| def queue_content_notifications(time=None) -> None: |
There was a problem hiding this comment.
I deeply dislike the approach being taken here, if anyone with sufficient SQLAlchemy knowledge wants to turn it into a single query with some joins I'd be very happy.
jellybob
force-pushed
the
push-notifications
branch
from
c9c21d5 to
77d4d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress PR, this handles the absolute basics of registering for push notifications, and being able to send a notification to an endpoint.
Things still to do:
send_queued_notificationsanddeliver_notification