Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add magnetometer driver & example app #70

Merged
merged 2 commits into from
Jun 4, 2022
Merged

Add magnetometer driver & example app #70

merged 2 commits into from
Jun 4, 2022

Conversation

davea
Copy link
Contributor

@davea davea commented Jun 4, 2022

For #63

tomsci
tomsci reviewed Jun 4, 2022
View reviewed changes
modules/accel_app/__init__.py Outdated
@@ -2,7 +2,7 @@
import tidal
import accelerometer

class Accel(TextApp):
class Accel(app.TextApp):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextApp was explicitly imported from app, so does this actually work? If you were wanting to make it consistent can you update the import as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, don't know how that crept in. Have pushed a fixup commit.

@tomsci
Copy link
Contributor

tomsci commented Jun 4, 2022

Excellent, thanks!

@tomsci tomsci merged commit 7422ee5 into emfcamp:main Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsci tomsci tomsci left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davea @tomsci