Switched to BufferedLockedHeap #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add BufferedLockedHeap to this PR, removing it from Heap-Layers. Thanks! |
emeryberger
requested changes
Aug 14, 2017
| #include <mutex> | ||
| #include <cstddef> | ||
|
|
||
| #ifndef thread_local |
There was a problem hiding this comment.
This looks like a nice way to identify thread local stuff across platforms, and one that should probably be factored out into a more generic include. Have you tested it with Windows, etc.?
There was a problem hiding this comment.
I have only tested it on Linux. See https://stackoverflow.com/a/18298965/3307716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.